Add option to increase max message size #246
Conversation
go/grpcwebproxy/backend.go
Outdated
| @@ -30,6 +30,12 @@ var ( | |||
| "Whether to ignore TLS verification checks (cert validity, hostname). *DO NOT USE IN PRODUCTION*.", | |||
| ) | |||
|
|
|||
| flagMaxMsgSize = pflag.Int( | |||
| "backend_max_msg_size", | |||
| 4194304, | |||
There was a problem hiding this comment.
Can we make this equivalent to the current max? https://github.com/grpc/grpc-go/blob/v1.8.2/server.go#L54. Also please add a reference to this line on github (i.e., copy this link). Note that the link is for v1.8.2 which is the version we've locked in Gopkg.toml.
There was a problem hiding this comment.
Do you mean to be explicit as 1024 * 1024 * 4 instead of the product? I'll add the link
go/grpcwebproxy/backend.go
Outdated
| flagMaxMsgSize = pflag.Int( | ||
| "backend_max_msg_size", | ||
| 4194304, | ||
| "Maximum message size limit. If not specified, the default of 4MB will be used.", |
There was a problem hiding this comment.
receive size limit.
|
Apologies, I still struggled to compile the binary after I've also added some documentation for the option on the README, so we can take care of that while we're at it. |
|
Let's just see how the build goes but the code LGTM. |
|
I might not be able to immediately use the updated binary, my go won't compile, errors with $GOPATH. Do you know if Travis generates build artifacts? |
nevi-me
changed the title
|
I don't think Travis does. It really should not be hard to build if you have go installed already. Have you checked the README in the grpcwebproxy folder? It has a step by step guide. |
|
Thanks for your contribution! |
|
I got dep installed, but when I |
|
😬 this is probably easier to resolve in a chat: there's a gRPC-Web slack you can join and we can debug your setup in there: https://join.slack.com/t/improbable-eng/shared_invite/enQtMzQ1ODcyMzQ5MjM4LWY5ZWZmNGM2ODc5MmViNmQ3ZTA3ZTY3NzQwOTBlMTkzZmIxZTIxODk0OWU3YjZhNWVlNDU3MDlkZGViZjhkMjc |
Adds the option to pass an integer value as the
grpc.WithMaxMsgSizefrom https://godoc.org/google.golang.org/grpc#WithMaxMsgSize, https://github.com/grpc/grpc-go/blob/master/dialoptions.go#L147.ref #245