Configurable Transports and Extraction of the Node HTTP Transport

grpc-web-node-http-transport/README.md

@@ -0,0 +1,16 @@
+# grpc-web-node-http-transport
+Node HTTP Transport for use with [grpc-web-client](https://github.com/improbable-eng/grpc-web)
+
+## Usage
+When making a gprc request, specify this transport:
+
+```
+import { grpc } from 'grpc-web-client';
+import { NodeHttpTransport } from 'grpc-web-node-http-transport';
+
+grpc.invoke(MyService.DoQuery, {
+  host: "https://example.com",
+  transport: NodeHttpTransport(),
+  /* ... */
+})
+```

grpc-web-node-http-transport/package.json

@@ -0,0 +1,24 @@
+{
+  "name": "grpc-web-node-http-transport",
+  "version": "0.0.1",
+  "description": "Node HTTP Transport for use with grpc-web-client",
+  "main": "lib/index.js",
+  "repository": {
+    "type": "git",
+    "url": "github.com/improbable-eng/grpc-web"
+  },
+  "scripts": {
+    "clean": "rm -rf lib",
+    "build": "tsc",
+    "test": "echo \"Error: no test specified\" && exit 1"
+  },
+  "dependencies": {
+    "grpc-web-client": "^0.6.3"
+  },
+  "author": "",
+  "license": "Apache-2.0",
+  "devDependencies": {
+    "@types/node": "^10.12.0",
+    "typescript": "^3.1.3"
+  }
+}

ts/src/transports/nodeHttp.ts → grpc-web-node-http-transport/src/index.ts

@@ -1,21 +1,19 @@
 import * as http from "http";
 import * as https from "https";
 import * as url from "url";
-import {Transport, TransportOptions} from "./Transport";
-import {Metadata} from "../metadata";
+import { grpc } from 'grpc-web-client';
 
-/* nodeHttpRequest uses the node http and https modules */
-export default function nodeHttpRequest(options: TransportOptions): Transport {
-  options.debug && console.log("nodeHttpRequest", options);
-
-  return new NodeHttp(options);
+export function NodeHttpTransport(): grpc.TransportFactory {
+  return (opts: grpc.TransportOptions) => {
+    return new NodeHttp(opts);
+  };
 }
 
-class NodeHttp implements Transport {
-  options: TransportOptions;
+class NodeHttp implements grpc.Transport {
+  options: grpc.TransportOptions;
   request: http.ClientRequest;
 
-  constructor(transportOptions: TransportOptions) {
+  constructor(transportOptions: grpc.TransportOptions) {
     this.options = transportOptions;
   }
 
@@ -31,7 +29,7 @@ class NodeHttp implements Transport {
   responseCallback(response: http.IncomingMessage) {
     this.options.debug && console.log("NodeHttp.response", response.statusCode);
     const headers = filterHeadersForUndefined(response.headers);
-    this.options.onHeaders(new Metadata(headers), response.statusCode!);
+    this.options.onHeaders(new grpc.Metadata(headers), response.statusCode!);
 
     response.on("data", chunk => {
       this.options.debug && console.log("NodeHttp.data", chunk);
@@ -44,7 +42,7 @@ class NodeHttp implements Transport {
     });
   };
 
-  start(metadata: Metadata) {
+  start(metadata: grpc.Metadata) {
     const headers: { [key: string]: string } = {};
     metadata.forEach((key, values) => {
       headers[key] = values.join(", ");
@@ -105,7 +103,3 @@ function toBuffer(ab: Uint8Array): Buffer {
   }
   return buf;
 }
-
-export function detectNodeHTTPSupport(): boolean {
-  return typeof module !== "undefined" && module.exports;
-}

grpc-web-node-http-transport/tsconfig.json

@@ -0,0 +1,28 @@
+{
+  "compilerOptions": {
+    "alwaysStrict": true,
+    "sourceMap": true,
+    "declaration": true,
+    "declarationDir": "lib",
+    "target": "es5",
+    "removeComments": true,
+    "noImplicitReturns": true,
+    "noImplicitAny": true,
+    "noUnusedLocals": true,
+    "noUnusedParameters": true,
+    "strictNullChecks": true,
+    "stripInternal": true,
+    "noFallthroughCasesInSwitch": true,
+    "outDir": "lib",
+    "noEmitOnError": true
+  },
+  "types": [
+    "node"
+  ],
+  "include": [
+    "src"
+  ],
+  "exclude": [
+    "node_modules"
+  ]
+}

link-npm-modules.sh

@@ -0,0 +1,13 @@
+#!/bin/bash
+set -e
+
+# Link the modules present in this repo so the tests run with
+# the latest sources instead of those fetched from npm.
+
+# Link local modules into the global store
+pushd ts && npm link && popd
+pushd grpc-web-node-http-transport && npm link && popd
+
+# Link dependencies from the global store
+pushd grpc-web-node-http-transport && npm link grpc-web-client && popd
+pushd test && npm link grpc-web-node-http-transport && popd

package.json

@@ -1,7 +1,8 @@
 {
   "name": "grpc-web-ci",
   "scripts": {
-    "install": "(cd ts && npm install) && (cd test && npm install)",
+    "install": "(cd ts && npm install) && (cd test && npm install) && (cd grpc-web-node-http-transport && npm install)",
+    "postinstall": "./link-npm-modules.sh && (cd ts && npm run lib:build) && (cd grpc-web-node-http-transport && npm run build)",
     "test": "cd test && npm run test"
   },
   "author": "Improbable",