Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service worker fix for AbortController call #443

Merged
merged 1 commit into from
May 23, 2019

Conversation

midan888
Copy link
Contributor

window.AbortController changed to self.AbortController to work in both worker and window environments

Changes

Verification

Copy link
Contributor

@jonnyreeves jonnyreeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand this will fix the issue within the web worker environment, but don't we need to reference the window object when running in a browser? I was under the impression that the self object will be undefined.

@midan888
Copy link
Contributor Author

@jonnyreeves No, self global object exists in a browser as well https://developer.mozilla.org/en-US/docs/Web/API/Window/self.

And I don't understand why one test failed, could you help with that ?

@jonny-improbable
Copy link
Contributor

@jonnyreeves No, self global object exists in a browser as well https://developer.mozilla.org/en-US/docs/Web/API/Window/self.

Today I learned 🤯

And I don't understand why one test failed, could you help with that ?

Edge tests are flakey; I've restarted the job and will merge on green. 🤞

Copy link
Contributor

@jonny-improbable jonny-improbable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

legit!

@jonny-improbable jonny-improbable merged commit 62b2d2d into improbable-eng:master May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants