Revert "Check flusher interface before calling Flush (#479)" #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cf7d15a. This introduced a recursive call to `Flush` in the proxy, which will crash the application.
| @@ -95,7 +90,7 @@ func (w *grpcWebResponse) finishRequest(req *http.Request) { | |||
| w.copyTrailersToPayload() | |||
| } else { | |||
| w.WriteHeader(http.StatusOK) | |||
| w.Flush() | |||
There was a problem hiding this comment.
@johanbrandhorst whilst we wait for CI to go green on this PR...
...isn't this the root cause of the issue? Shouldn't this be replaced with a safe up-cast on w.wrapped before calling Flush()?
There was a problem hiding this comment.
I haven't looked at it in detail, lets discuss after merging the fix.
|
Given this failure has had an impact on consumers, it implies we are missing a test. @light0x, would you be in a position to help us contribute a test-case which would help us catch this regression in future, please? |
jonny-improbable
approved these changes
Aug 6, 2019
Merged
|
Rerunning failed tests |
|
Given that the 2 failures occurred on older versions of Chrome I am happy to chalk the failure down to BrowerStack flakiness and will use Admin powers to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit cf7d15a.
This introduced a recursive call to
Flushin the proxy, whichwill crash the application.