Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate CI to CircleCI & SauceLabs #823

Merged
merged 18 commits into from
Jan 4, 2021

Conversation

MarcusLongmuir
Copy link
Contributor

@MarcusLongmuir MarcusLongmuir commented Dec 31, 2020

This PR migrates this project's CI from Travis CI and BrowserStack to circleci and SauceLabs for CI environment and browser testing respectively.

This has been done in an attempt to improve both the stability and reduce the test duration of a CI run of the project.

Whilst in my testing this configuration is also liable to flake (at a rate that appears reduced compared to the current setup) the retries are quicker to run and therefore the impact is reduced.

This change is limited only to CI configuration and does not affect the published packages. However, the change to the CI configuration is substantial and some tests have been modified in the interests of stability.

This will require rebasing open PRs, but should result in an easier PR flow for contributors.

I'll hold off on merging this until the organisation settings are changed on CircleCI to make the project visible without signing in.

image

@improbable-prow-robot improbable-prow-robot added the size/XXL Denotes a PR that changes 600+ lines, ignoring generated files. label Dec 31, 2020
@johanbrandhorst
Copy link
Contributor

This is awesome, thanks for taking the time to do this Marcus! I will have a closer look tomorrow, just wanted to say that 😄.

Copy link
Contributor

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, some minor questions from me.

integration_test/go/testserver/testserver.go Outdated Show resolved Hide resolved
integration_test/go/testserver/testserver.go Outdated Show resolved Hide resolved
integration_test/go/testserver/testserver.go Show resolved Hide resolved
Copy link
Contributor

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢, excited about this!

@MarcusLongmuir MarcusLongmuir merged commit f9ddeb1 into master Jan 4, 2021
@MarcusLongmuir MarcusLongmuir deleted the develop/saucelabs-circleci-migration branch January 4, 2021 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 600+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants