Remove some unused packages and provide a Writer base class #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@afedynitch @jncots Can I get a review on this? It is not a big change. |
afedynitch
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During writing of the ICRC proceeding, I noticed that it would be more consistent to have a base class for the Writer classes. This patch adds such a base class and makes the other classes derive from it. I think we originally had such a base class, but I removed it when I removed all the writer classes. At the time, I thought we don't need them, but I then realized that we need them for the CLI.
In addition, I removed the graphviz package from the list of packages needed for testing, which is no longer necessary since I replaced the graphviz code in pyhepmc.