-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test of final state #160
Test of final state #160
Conversation
So, I found the issues with PHOJET and likely with DPMJET decays, and the mystery difference between 19.1 and 19.3. I actually cleaned up these subroutines in 19.3, not perfectly, but there is some improvement :) I need to backport 19.3 to 19.1 because no Omega- is definitely a bug. |
@HDembinski Sorry, I hijacked your PR to make substantial fixed to the decays in all of the PHOJET/DPMJET models. I identified the issues and fixed them directly in the fortran codes and also in chromo. I can't request a review from you, but nonetheless I think you can do a review or comment if you wish. I also changed the base of the PR to be the branch we're preparing for release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. Finally decaying particles will decay.
This PR fixes the issues with DPMJET and PHOJET models, which didn't follow the decay settings controlled by chromo, and adds a test which checks that all particles which we expect to occur in the final state actually occur for all models.
Two exceptions are built into the test:
The PR fixes the following problems to make the test pass:
chromo
. The minor version of both codes have been upped by one to reflect the minor change.This PR closes #156.