-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from LFS #75
Migrate from LFS #75
Conversation
Just for starters I add a couple of functions in |
The code is taken from MCEq with minor changes. |
In the previous commits I was trying to build Pythia8 on Windows. There were a problem with dlfcn-win32 library, or to be exactly |
I excluded Pythia8 on Windows from building and from tests. I leave here the notes about building problem with Pythia8 on Windows.
|
PR can be closed if no other requirements |
The main goal of the PR - moving from LFS - has been reached. Another task - build and pass tests on Windows - has been done partially. There are problems with two models Pythia8 and UrQMD. Both models don't load with errors related to dlls. Currently I removed these models from building and tests on Windows. @HDembinski do you have any idea why Pythia8 build fails on Windows? I propose to close this PR. @afedynitch, @HDembinski what do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still a few things, which could be improved. Like removal of files or paths from the config because they are not used anymore.
One issue I'd like to see fixed is that the paths to the files in DPMJET, these paths should class vars, so by subclassing one can easily overwrite them.
I second that. Edit: The remote path as a string can be a classvar, but the call to |
I am fine with that solution. Ideally, Pythia8 and UrQMD should not be importable from impy.models if they are not available on a platform. I am not sure about the easiest and most efficient way to achieve this at the moment. We should not add complicated code to impy to handle this edge case just for a negliglbe user base that runs Windows.
No, and I don't think it is worth any more effort in making Pythia8 work on Windows. If Pythia8 is not officially supported on Windows by the Pythia8 authors, we should not try to make it work (unless it was easy to do). The user base on Windows is neglgible.
I am ok with that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all of Anatoli's last requests are met.
Yea, let's merge. On the Pythia8 Windows mystery: it's not related to Pythia8's code but rather the whole python bindings, dynamic libs vs static libs stuff. It's a bit mysterious. For UrQMD, I agree that the user base is tiny and it's not worth putting any time into it. |
Currently the data tables in directory iamdata which are used by some models are located on LFS. This doesn't allow to test all models on CI. That should be changed by attaching binary files to release on github. The tables should be downloaded automatically by python when they are required.
This PR is opened to solve this problem.