-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise error early when invalid arguments are provided to .apply_async
#54
Comments
imranariffin
added a commit
that referenced
this issue
Jul 18, 2023
* Run validation on the arguments using the `inspect.Signature.bind` built-in utility * If invalid, raise error. Otherwise, proceed to sending task to queue * This aims to help user identity bug early on * We might consider turning this feature on only when AIOTASKQ_DEBUG=1 or something like that in the future
imranariffin
added a commit
that referenced
this issue
Jul 18, 2023
* Run validation on the arguments using the `inspect.Signature.bind` built-in utility * If invalid, raise error. Otherwise, proceed to sending task to queue * This aims to help user identity bug early on * We might consider turning this feature on only when AIOTASKQ_DEBUG=1 or something like that in the future
imranariffin
added a commit
that referenced
this issue
Jul 18, 2023
* Run validation on the arguments using the `inspect.Signature.bind` built-in utility * If invalid, raise error. Otherwise, proceed to sending task to queue * This aims to help user identity bug early on * We might consider turning this feature on only when AIOTASKQ_DEBUG=1 or something like that in the future Bump version to 0.0.12
imranariffin
added a commit
that referenced
this issue
Jul 22, 2023
* Run validation on the arguments using the `inspect.Signature.bind` built-in utility * If invalid, raise error. Otherwise, proceed to sending task to queue * This aims to help user identity bug early on * We might consider turning this feature on only when AIOTASKQ_DEBUG=1 or something like that in the future Bump version to 0.0.12 Signed-off-by: Imran Ariffin <ariffin.imran@gmail.com>
imranariffin
added a commit
that referenced
this issue
Jul 22, 2023
* Run validation on the arguments using the `inspect.Signature.bind` built-in utility * If invalid, raise error. Otherwise, proceed to sending task to queue * This aims to help user identity bug early on * We might consider turning this feature on only when AIOTASKQ_DEBUG=1 or something like that in the future Bump version to 0.0.12 Signed-off-by: Imran Ariffin <ariffin.imran@gmail.com>
imranariffin
added a commit
that referenced
this issue
Jul 22, 2023
* Run validation on the arguments using the `inspect.Signature.bind` built-in utility * If invalid, raise error. Otherwise, proceed to sending task to queue * This aims to help user identity bug early on * We might consider turning this feature on only when AIOTASKQ_DEBUG=1 or something like that in the future Bump version to 0.0.12 Signed-off-by: Imran Ariffin <ariffin.imran@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, we don't do any validation to the arguments provided, so we publish the tasks with the invalid argument and wait for the result. The result will never come because the worker fails to execute the task due to invalid argument.
We can reproduce this way:
We need to raise error early like this:
The text was updated successfully, but these errors were encountered: