Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug that upload speed is not tabulated correctly #116

Merged
merged 1 commit into from
Jan 14, 2020

Conversation

zhangxp1998
Copy link
Collaborator

@zhangxp1998 zhangxp1998 commented Jan 14, 2020

Fix issue #115

The bug is here:

.filter_map(Result::ok)

We filtered network_frames iterator but not network_interfaces. As a result, these two vectors go out of sync. That is why sometimes the sniffer thread receive packets from inactive interfaces. Since inactive interfaces don't have IP addr, sniffer assumed that packets are all in download direction

Copy link
Owner

@imsnif imsnif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!!

@imsnif imsnif merged commit be53165 into imsnif:master Jan 14, 2020
@zhangxp1998 zhangxp1998 deleted the upload_speed branch January 14, 2020 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants