-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need better clarity on bundle filename for chains of attestations #107
Comments
Yes, agreed.
I wonder if this should cover "attestations produced during the artifact's SDLC"? |
Here's how I see it potentially playing out. I am OK with duplicating an attestation across for multiple artifacts if that one attestation has multiple subjects. Since we have jsonl we can do stuff like: Attestation A refers to Artifact 1 and Artifact 2. artifact1.jsonl can contain Attestation A and Attestation B. Just want to clarify there that however we word it, it should support the above use case. |
I agree with that. I think it would also be fine if artifact1.jsonl contained Attestation A, B, and C. I.e. it's fine (but not optimal) if the bundle contains attestations that aren't applicable. |
feedback from sigstore/sigstore-python#223 (comment): need the version number in the filename, |
Please see #115 for a potential fix. |
Clarify bundle naming convention Fixes #107
The current bundle file naming convention is misleading for the case when the bundle is a set of dependent attestations that are all "about" a single artifact but have different subjects. Current wording:
The phrase "concern a single artifact" needs more specificity. It could be read two ways:
<artifact>
, name itmultiple.intoto.jsonl
.<artifact filename>.intoto.jsonl
.cc: @shaunmlowry @TomHennen @mlieberman85
The text was updated successfully, but these errors were encountered: