Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid Solutions #8

Merged
merged 1 commit into from
Jun 30, 2016
Merged

Invalid Solutions #8

merged 1 commit into from
Jun 30, 2016

Conversation

elbrujohalcon
Copy link
Member

@elbrujohalcon elbrujohalcon commented Jun 30, 2016 •
edited
Loading

The server should reply with proper warnings in the following scenarios:

  • improper input (not a map, not a fun, etc.)
  • invalid input (not a registred user, invalid node, etc.)
  • timeout (the provided fun fails to run in the expected time)
  • tests not passing (the provided fun doesn't respect a test case)

@elbrujohalcon elbrujohalcon self-assigned this Jun 24, 2016
gadgetci
gadgetci reviewed Jun 30, 2016
View reviewed changes
src/tasks/bo_task.erl

-export([describe/1, test/2]).

-spec describe(module()) -> bo_task:task().
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to Xref:

type task() undefined

@gadgetci
Copy link
Member

xref failed with exit status: 1

@HernanRivasAcosta
Copy link
Member

Me gusto

@amilkr amilkr merged commit 2f88b32 into master Jun 30, 2016
@amilkr amilkr deleted the elbrujohalcon.8.invalid_solutions branch June 30, 2016 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@amilkr amilkr

@HernanRivasAcosta HernanRivasAcosta

Labels
finished
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elbrujohalcon @gadgetci @HernanRivasAcosta @amilkr