Maintenance updates #573
Merged
Maintenance updates #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before starting to change files in the scope of this branch
This was a throw, before, and was "handled" in the testing env. It was recently changed to an error, and stopped being handled The formatter removed throw: from the catch, which ended up making it even harder to find We thus restore some sanity :)
elvis_core used to throw from https://github.com/inaka/elvis_core/blob/main/src/elvis_config.erl#L45 It doesn't anymore, which means this test fails
We need to "fake" elvis_config:files/1 too, otherwise we're not "loading" anything...
Only keep generated stuff + _* (e.g. for _build and _checkouts)
Bump versions Add format verifications Restore full test SUITE
- tweaks erl_opts - updates versions for dep and plugins - removed ct_compile_opts - moves ct specific options to profile `test` - adds minimum_otp_vsn - tweaks dialyzer options (removing defaults) - adds ex_doc - adds xref - adds format
|
These apparently need some adjustment in the Settings: |
The README.md fix (for reference) is just a bonus!
elbrujohalcon
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't as big as it looks, though there's possibly a lotta changes.
I'll self-review and try to guide you through it to ease the task.
Whenever a change is not super-explicit or supported by the commit message I'll add a comment.
Edit: many of the changes in the source files occur because of bebcbc6.
Closes #569.