Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][#40] updating dependencies #47

Merged
merged 1 commit into from
Oct 12, 2018

Conversation

ferigis
Copy link
Member

@ferigis ferigis commented Oct 12, 2018

[close #40]

@codecov-io
Copy link

codecov-io commented Oct 12, 2018

Codecov Report

Merging #47 into master will decrease coverage by 0.88%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
- Coverage   95.15%   94.27%   -0.89%     
==========================================
  Files          11       11              
  Lines         227      227              
==========================================
- Hits          216      214       -2     
- Misses         11       13       +2
Impacted Files Coverage Δ
src/sheldon_suggestions_server.erl 53.33% <0%> (-13.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d696211...cb6c2fb. Read the comment docs.

@ferigis ferigis requested a review from elbrujohalcon October 12, 2018 15:55
@ferigis
Copy link
Member Author

ferigis commented Oct 12, 2018

Codecov is doing a weird calculation since I didn't change code and everything looks the same. After this PR I will work on #48 in order to get the 100% coverage

@ferigis ferigis added the WIP 🚧 Work In Progress label Oct 12, 2018
@ferigis ferigis changed the title [#40] updating dependencies [WIP][#40] updating dependencies Oct 12, 2018
@elbrujohalcon elbrujohalcon merged commit 63cfdce into master Oct 12, 2018
@ferigis ferigis deleted the ferigis.40.update_dependencies branch October 12, 2018 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP 🚧 Work In Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Dependencies
3 participants