Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split transport_opts into tcp_opts and tls_opts for gun2 #194

Merged
merged 2 commits into from
Feb 2, 2023

Conversation

phunehehe
Copy link
Collaborator

This makes shotgun compatible with gun v2 (and incompatible with gun v1)
gun v2 has been in RC for a while now
#193

@phunehehe phunehehe mentioned this pull request Sep 26, 2022
@elbrujohalcon
Copy link
Member

Hi @phunehehe … I'm merging this one now and I invited you to be a maintainer of this repository so you can push changes to it, publish it on hex.pm and do whatever else you need with it :)

@elbrujohalcon elbrujohalcon merged commit 356a53b into inaka:master Feb 2, 2023
@phunehehe phunehehe deleted the gun2 branch February 3, 2023 16:45
@phunehehe
Copy link
Collaborator Author

Thanks!
I have accepted the invite. I don't have any plan for the near future but let's see :)

@phunehehe phunehehe restored the gun2 branch February 3, 2023 21:29
@beligante
Copy link

Good Morning shotgun team!

Are you guys open to drafting a release for this update? I'm pointing to the latest master ref, but my project requires official releases - for regulatory purposes. Thanks In advance

@phunehehe
Copy link
Collaborator Author

@beligante I took the liberty to make a 1.0.0 release. Not sure if anything else is needed, I'm not familiar with the release process. I'm using it in production, but I'm marking it pre-release anyway as a precaution.

@elbrujohalcon
Copy link
Member

Release away, @phunehehe !! Go for it!
You folks are the most prominent (and quite possibly the only) real users of this library.
Do whatever you see fit with it.

@phunehehe
Copy link
Collaborator Author

@elbrujohalcon This library is used by launchdarkly/erlang-server-sdk which is somewhat popular and active. It's the only thing that requires Gun 1 in my system and that was why I ended up here
I bet there are other silent users as well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants