199 rework timeseries creation to contain species with observation after 1950 #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
success 💪 🥳 |
|
@SanderDevisscher deze PR mag gereviewed worden, nu de flow weer werkt :) |
SanderDevisscher
requested changes
Jul 17, 2024
There was a problem hiding this comment.
Since we changed the name of this script to cube_preprocessing (see #201) it is best to do the following (in order):
- rename 05_occurrence_indicators_preprocessing.Rmd to cube_preprocessing on this branch
- do a rebase to make sure other changes in cube_preprocessing are included
- solve possible conflicts
- solve other issues
| @@ -368,15 +368,15 @@ df_bl_xy %>% head() | |||
|
|
|||
| ## Apply temporal and spatial restraints | |||
|
|
|||
| Select alien species introduced after 1950 (`year_of_introduction`: 1950) or whose date of introduction is not known: | |||
| Select alien species that were observed after 1950 (`year_cutoff`: 1950) or whose date of introduction is not known: | |||
|
|
|||
| ```{r select_aliens_after_year_of_introduction} | |||
There was a problem hiding this comment.
select aliens with recent observations?
|
|
||
| ```{r n_recent_taxa} | ||
| nrow(recent_alien_species) | ||
| ``` | ||
|
|
||
| List of alien species excluded as first introduction date is earlier than 1950: | ||
| List of alien species excluded as last observation date is earlier than 1950: | ||
|
|
||
| ```{r recent_alien_species} |
There was a problem hiding this comment.
extinct_alien_species ?
| @@ -430,24 +430,24 @@ old_introductions_taxa <- | |||
| old_introductions_taxa | |||
| ``` | |||
|
|
|||
| We save them in file `taxa_introduced_in_BE_before_1950.tsv` in `data/output`: | |||
| We save them in file `taxa_last_observed_in_BE_before_1950.tsv` in `data/output`: | |||
|
|
|||
| ```{r save_old_introduced_taxa_as_tsv_file} | |||
There was a problem hiding this comment.
save_last_observed_before ?
|
Rebase with uat? |
yes |
I got the following error: A lock file already exists in the repository, which blocks this operation from completing. any ideas? |
soriadelva
force-pushed
the
199-rework-timeseries-creation-to-contain-species-with-observation-after-1950
branch
from
32fede4 to
eeb972d
Compare
SanderDevisscher
approved these changes
Jul 19, 2024
SanderDevisscher
deleted the
199-rework-timeseries-creation-to-contain-species-with-observation-after-1950
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
null