Adds write_dwc() function (v1)
#119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently generates metadata only
peterdesmet
added a commit
to inbo/movepub
that referenced
this pull request
Jun 3, 2022
damianooldoni
approved these changes
Jun 8, 2022
There was a problem hiding this comment.
Thanks @peterdesmet for adding this important function to the package! Very much appreciated.
And I also appreciated both your improvements of the style of some other functions and the documentation.
As you wrote in the function itself, there are some TODO still. Could you please put them in issues, please? Then we can get an overview about the work to do. Another TODO task to add as issue as well is writing unit-tests for this function, am I right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
write_dwc()function similar to https://inbo.github.io/movepub/reference/write_dwc.html that generates EML + DwC data. Does not yet take into account the changes suggested in tdwg/camtrap-dp#203.