consoles: Make DirectoryRoleBinding optional #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the workloads controller has a hard dependency on `DirectoryRoleBinding`s, as provided by the RBAC controller, in order to create consoles. If you try to do this, without having the RBAC controller installed, then the reconcile loop gets stuck, as the rolebinding to access the console can't be provisioned. This is a bit presumptuous; it should be possible to run consoles without DRBs, e.g. if you just want to reference plain `User` kinds in `additionalAttachSubjects`. This change adds a flag, which makes the usage of `DirectoryRoleBinding` optional. The flag defaults to true, meaning that this isn't a breaking change. We intended to use this in conjunction with [Google Groups for RBAC][0] as an alternative. [0]: https://cloud.google.com/kubernetes-engine/docs/how-to/google-groups-rbac
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the workloads controller has a hard dependency on
DirectoryRoleBindings, as provided by the RBAC controller, in order to create consoles. If you try to do this, without having the RBAC controller installed, then the reconcile loop gets stuck, as the rolebinding to access the console can't be provisioned.This is a bit presumptuous; it should be possible to run consoles without DRBs, e.g. if you just want to reference plain
Userkinds inadditionalAttachSubjects.This change adds a flag, which makes the usage of
DirectoryRoleBindingoptional. The flag defaults to true, meaning that this isn't a breaking change.We intended to use this in conjunction with Google Groups for RBAC as an alternative.