Update controller-runtime to v0.16.3 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will include the large change mentioned here: https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.15.0 While here, also change the module path, as this looks to be the proper way of doing things.
Make this compile again, as some options have been moved around.
This brings in the new k8s 1.28.0 fields values.
We're using k8s v1.28 APIs, so let's go to the latest available Kind image, to run a 1.27 cluster.
Our app was being deployed before `cert-manager` was fully up and running, leading to theatre pods stuck in a `ContainerCreating` state, due to a missing secret volume.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why have we done this? To move past old versions of libraries, such as
k8s.io/api, which have transitive dependencies on the pre-1.0go.opentelemetry.io/otellibrary.Commits in order:
commit 4fa0ddf Update controller-runtime to v0.16.3
This will include the large change mentioned here: https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.15.0
While here, also change the module path, as this looks to be the proper
way of doing things.
commit de88551 Update controllers for new controller-runtime APIs
Make this compile again, as some options have been moved around.
commit 7969e20 Regenerate manifests
This brings in the new k8s 1.28.0 fields values.
commit 2e7963f Update kind version
We're using k8s v1.28 APIs, so let's go to the latest available Kind
image, to run a 1.27 cluster.
commit b384c1c Fix race condition in acceptance tests
Our app was being deployed before
cert-managerwas fully up andrunning, leading to theatre pods stuck in a
ContainerCreatingstate,due to a missing secret volume.
commit aeda687 Fix logger warning in acceptance tests
commit ee83746 v5.0.0
Bump the major version, as we've upgraded many things, and may have lost
compatibility with older clusters.