Add remote ruleset to woke configuration #28
Conversation
pkg/config/config.go
Outdated
| _, err = io.Copy(out, resp.Body) | ||
| return err | ||
| } else { | ||
| return fmt.Errorf("unable to download remote config from url - http response code: %v", resp.StatusCode) |
There was a problem hiding this comment.
Totally agree with returning the error here -- maybe we should also log.Error() the msg/body of the http response here as well? Just thinking it might provide more detailed information in case the remote server sent relevant info in the response body
There was a problem hiding this comment.
Added in the response body to the error message!
| }) | ||
|
|
||
| t.Run("invalid-url", func(t *testing.T) { | ||
| boolResponse := isValidURL("/Users/Document/test.yaml") |
There was a problem hiding this comment.
Out of curiosity, do you know if something like C:\user\test.yaml or C:\directory.com\test.yaml returns valid? Unsure how the URL validation works under the hood and just thinking of some weird edge cases
There was a problem hiding this comment.
it returns invalid - adding in some more unit tests
pkg/config/config.go
Outdated
|
|
||
| // downloads file from url to set filepath | ||
| func DownloadFile(filepath string, url string) error { | ||
| // Removing gosec lint warning - as we have to pass in user specified url for remote config |
There was a problem hiding this comment.
This comment looks like it's from when we were doing http.Get() to document that we were suppressing the linting warnings -- is it still needed?
There was a problem hiding this comment.
Good call - forgot to remove the warning !
pkg/config/config.go
Outdated
| log.Debug().Str("filename", filename).Msg("Saved remote config to local file.") | ||
| } | ||
|
|
||
| // TO DO = Need to add more error handling on reading/validating yamlFile file - issue # 16 |
There was a problem hiding this comment.
I think this is fine keeping the TODO item here for visibility, but keep in mind referencing issue #16 upstream won't make sense.
There was a problem hiding this comment.
good call - i may just remove for now
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
Link to issue: #1
What is the new behavior (if this is a feature change)?
This PR adds functionality to pull in remote rules from urls - https.
To test this PR:
go build
go run main.go -c "https://raw.githubusercontent.com/get-woke/woke/main/example.yaml" --debug
To test a 404 URL:
go run main.go -c "https://raw.githubusercontent.com/get-woke/woke/main/example" --debug