-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump actions/setup-node from 3 to 4 in /actions/publish #76
Bump actions/setup-node from 3 to 4 in /actions/publish #76
Conversation
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3 to 4. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v3...v4) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
actions/setup-nodeとは?
このアクションは下記の機能を提供している。 公式より引用
GitHub Actionsとは?GitHubリポジトリ内でカスタムワークフローを定義し、ビルド、テスト、デプロイなどのタスクを自動化するためのツール |
actions/setup-node 3から4の変更点
|
@@ -14,7 +14,7 @@ inputs: | |||
runs: | |||
using: "composite" | |||
steps: | |||
- uses: actions/setup-node@v3 | |||
- uses: actions/setup-node@v4 | |||
with: | |||
node-version: "18.16.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝
actions/setup-node@v4
ではデフォルトでnodeのv20が使用されている。
バージョンを指定して、デグレさせた場合不具合が起きる可能性もあるので調査する必要がありそう。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basic
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18
- run: npm ci
- run: npm test
Examples:
Major versions: 14, 16, 18
nodeバージョン18はサポートされている。
setup-node
は指定されたバージョンのNode.jsをインストールするためのアクションだから、
アクションそのもののバージョンが20になってもインストール先としてサポートしていれば良さそう。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kimkim0814 が見てくれた内容で問題なさそう。 LGTM
Bumps actions/setup-node from 3 to 4.
Release notes
Sourced from actions/setup-node's releases.
... (truncated)
Commits
8f152de
Update actions/checkout for documentation and yaml (#876)23755b5
upgrade actions/checkout to v4 (#868)54534a2
Change node version for action to node20 (#866)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)