-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ajout de conditions transport + corrige actions + corrige hybride (NGC-941) #2399
Merged
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
b7842a9
chore: ajout de conditions supplémentaires sur les km
Clemog 3b5fa51
temp: disable wrong action
Clemog e474d3b
fix: conditions actions
Clemog 927d92e
fix: again
Clemog e1470e2
fix: questions voyageurs non répondue par défaut
Clemog bf88750
fix: corrige empreinte au kilomètre hybride
Clemog 5a619ba
Merge branch 'preprod' into fix-conditions-voiture
Clemog 253d409
fix: actions avec recalculs avec km
Clemog aca0fcd
Merge branch 'preprod' into fix-conditions-voiture
Clemog 1cd0b75
fix: règle empreinte au kilomètre utilisée
Clemog b7b1646
fix: ajouts de calculs intermédiaires
Clemog 20f02a1
chore: refacto
Clemog 50ac09c
temp: désactivaiton des actions problématiques
Clemog f19422d
Revert "temp: désactivaiton des actions problématiques"
Clemog 01bd5a8
fix: oubli condition hybride
Clemog 83a5934
fix: plus de recalcul pour le barème hybride
Clemog dfc011c
Merge branch 'preprod' into fix-conditions-voiture
Clemog 100e17b
feat: traduction
Clemog 3371257
fix: oubli facteur 2
Clemog 8fa352b
chore: typo
Clemog 71ad291
Merge branch 'preprod' into fix-conditions-voiture
Clemog File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
L'action n'est pas applicable pour Marie car
voiture . utilisateur
n'est pas défini. Ne faudrait-il pas ajouter un "propriétaire" par défaut ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je pense que c'est bien de s'assurer que la personne est propriétaire pour cette action
Et du coup, pourquoi utilisateur n'est pas à "propriétaire" par défaut : c'est bien le cas dans le contexte de l'empreinte moyenne .. Mais l'action ne s'affiche pas tant que la personne n'a pas répondu (plutot logique je pense)