fix(tableIcon): fix tap icon when onPress is undefined #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navarroaxel
suggested changes
Mar 16, 2018
src/Table/TableIcon.js
Outdated
| @@ -15,7 +15,7 @@ const TableIcon = ({column, datum}) => ( | |||
| isFunction(column.icon) ? column.icon(datum) : column.icon, | |||
| isFunction(column.color) ? column.color(datum) : column.color | |||
| )} | |||
| onPress={() => column.onPress(datum)} | |||
| onPress={() => (column.onPress ? column.onPress(datum) : null)} | |||
There was a problem hiding this comment.
onPress={isFunction(column.onPress) ? (() => column.onPress(datum)) : undefined}
maximilianoforlenza
force-pushed
the
fixInconOnPress
branch
from
a05e561 to
4547ed8
Compare
|
listo |
navarroaxel
force-pushed
the
fixInconOnPress
branch
from
4547ed8 to
c18e4a2
Compare
navarroaxel
changed the title
navarroaxel
approved these changes
Mar 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(tableIcon): fix when press icon