IWF-122: add set search attributes and set data attributes #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuel27m
approved these changes
Nov 14, 2024
|
|
||
| @Override | ||
| public CommandRequest waitUntil(Context context, String input, Persistence persistence, Communication communication) { | ||
| return CommandRequest.forAnyCommandCompleted(SignalCommand.create("__IwfSystem_ExecuteRpc", 1)); |
There was a problem hiding this comment.
That's a neat trick. TIL 🙌
samuel27m
reviewed
Nov 14, 2024
| @@ -30,8 +30,10 @@ for run in {1..120}; do | |||
| sleep 0.1 | |||
| temporal operator search-attribute create --name CustomStringField --type Text | |||
| sleep 0.1 | |||
| temporal operator search-attribute create --name CustomKeywordArrayField --type KeywordList | |||
There was a problem hiding this comment.
Could you do the same update in the IWF docker init script? This one: https://github.com/indeedeng/iwf/blob/main/docker-compose/init-ci-temporal.sh
There was a problem hiding this comment.
Sorry I missed it, you already have that created! Apologies!!
lwolczynski
approved these changes
Nov 14, 2024
samuel27m
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Related Issue
Closes #<issue_number>