Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IWF-129: Enable executingStateIds SAs for states with waitUntil #453

Merged
merged 18 commits into from
Oct 24, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,8 @@ a version tag.
* See [Contribution](./CONTRIBUTING.md) for more detailed commands.
* For Cadence without advancedVisibility enabled,
set [disableSystemSearchAttributes](https://github.com/indeedeng/iwf/blob/main/config/development_cadence.yaml#L8)
to true
to true and [executingStateIdMode](https://github.com/indeedeng/iwf/blob/main/config/development_cadence.yaml#L9)
to DISABLED
* Then run `./iwf-server start` to run the service . This defaults to serve workflows APIs with Temporal interpreter
implementation. It requires to have local Temporal setup. See Run with local Temporal.
* Alternatively, run `./iwf-server --config config/development_cadence.yaml start` to run with local Cadence. See below
Expand Down
1 change: 1 addition & 0 deletions config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ type (
var DefaultWorkflowConfig = &iwfidl.WorkflowConfig{
ContinueAsNewThreshold: iwfidl.PtrInt32(100),
DisableSystemSearchAttribute: iwfidl.PtrBool(true),
ExecutingStateIdMode: iwfidl.PtrString("ENABLED_FOR_STATES_WITH_WAIT_UNTIL"),
}
lwolczynski marked this conversation as resolved.
Show resolved Hide resolved

// NewConfig returns a new decoded Config struct
Expand Down
3 changes: 2 additions & 1 deletion config/development_cadence.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ api:
waitForOn: old
interpreter:
# interpreterActivityConfig:
# disableSystemSearchAttributes: true # set to true if you don't have advanced visibility in Cadence, see more https://github.com/uber/cadence/issues/5085
# disableSystemSearchAttributes: true # (deprecated) set to true if you don't have advanced visibility in Cadence, see more https://github.com/uber/cadence/issues/5085
# executingStateIdMode: DISABLED # set to true if you don't have advanced visibility in Cadence, see more https://github.com/uber/cadence/issues/5085
cadence:
hostPort: 127.0.0.1:7833
domain: default
Expand Down
Loading
Loading