Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IWF-124: Ignore empty output for collector #524

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

lwolczynski
Copy link
Contributor

@lwolczynski lwolczynski commented Dec 16, 2024

Description

Checklist

  • Code compiles correctly
  • Tests for the changes have been added
  • All tests passing
  • This PR change is backwards-compatible
  • This PR CONTAINS a (planned) breaking change (it is not backwards compatible)

Related Issue

Closes #issue_number

@lwolczynski lwolczynski force-pushed the jira/lwolczynski/IWF-124 branch from ce36ed4 to e3c0f58 Compare December 17, 2024 20:12
@lwolczynski lwolczynski marked this pull request as ready for review December 17, 2024 20:12
Copy link
Contributor

@longquanzheng longquanzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,
do we know we have existing test with output(we probably do)
if no, can we change one of the test to return a non-nil output so that we can test the case?

@lwolczynski
Copy link
Contributor Author

lgtm, do we know we have existing test with output(we probably do) if no, can we change one of the test to return a non-nil output so that we can test the case?

basic_test.go:
assertions.Equal(1, len(resp2.GetResults()))

conditional_close_test.go:
assertions.Equal(1, len(resp2.GetResults()))
assertions.Equal(expectedOutput, resp2.GetResults()[0])

skip_start_test.go:
assertions.Equal(1, len(resp2.GetResults()))

@lwolczynski lwolczynski force-pushed the jira/lwolczynski/IWF-124 branch from e3c0f58 to 6543355 Compare December 18, 2024 15:35
@lwolczynski lwolczynski enabled auto-merge (squash) December 18, 2024 15:35
@lwolczynski lwolczynski merged commit 20103a8 into main Dec 18, 2024
8 checks passed
@lwolczynski lwolczynski deleted the jira/lwolczynski/IWF-124 branch December 18, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants