Utilize SQLite close
#295
Comments
3 tasks
brettz9
added a commit
to brettz9/IndexedDBShim
that referenced
this issue
Apr 2, 2017
…ion fault"--but not closing in that test?
- Enhancement: For Node, utilize underlying SQLite3 `close` listener to wait
for genuine closing before reporting `close` event (indexeddbshim#295)
- Enhancement: For Node, treat any underlying SQLite3 `close` errors as force
close operations
- Refactoring (spec parity): Integrate force close logic into close logic (force close still untested)
brettz9
added a commit
to brettz9/IndexedDBShim
that referenced
this issue
Apr 4, 2017
…ion fault"--but not closing in that test?
- Enhancement: For Node, utilize underlying SQLite3 `close` listener to wait
for genuine closing before reporting `close` event (indexeddbshim#295)
- Enhancement: For Node, treat any underlying SQLite3 `close` errors as force
close operations
- Refactoring (spec parity): Integrate force close logic into close logic (force close still untested)
brettz9
added a commit
to brettz9/IndexedDBShim
that referenced
this issue
Apr 5, 2017
…ion fault"--but not closing in that test?
- Enhancement: For Node, utilize underlying SQLite3 `close` listener to wait
for genuine closing before reporting `close` event (indexeddbshim#295)
- Enhancement: For Node, treat any underlying SQLite3 `close` errors as force
close operations
- Refactoring (spec parity): Integrate force close logic into close logic (force close still untested)
|
It didn't seem to be possible to recover after such a close, so I'm not sure this would be of any use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As discussed in #294, we ought to be calling
nodeWebSQLDBInstance._db._db.close()under the right conditions, if not for freeing resources than for catching possible errors during closing.The text was updated successfully, but these errors were encountered: