Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #259 - Revert part of 66224374ec34a89d13a8daf207f485a986177117 #292

Merged
merged 1 commit into from
Feb 22, 2017

Conversation

erikvold
Copy link
Contributor

It seems that this code was providing a path that does not exist. I'm not quite sure why it was added in 6622437 @brettz9 ?

@erikvold
Copy link
Contributor Author

Note: Please see #291

@brettz9
Copy link
Collaborator

brettz9 commented Feb 22, 2017

I see, good catch and sorry for the headache--I bet this was a result of my trying to get things work when I was using a relative path. I'll merge locally and rerun all the tests (including in the browser) to be sure.

@brettz9
Copy link
Collaborator

brettz9 commented Feb 22, 2017

Actually, I see why I did it now... Notice that your path is now hard-baked into the package as mine had been a while back when the first report came in. I think browserify does it this way for the globals so I tried at least making it relative, but from everybody's reports, apparently that doesn't work in all environments (apparently when requiring outside of the IndexedDBShim package).

I think the solution is going to simply be to have the browserify process exclude websql/sqlite3. (If that doesn't work (though I think it should), we'd need to have the build run at install time in the case of Node, though that would require a lot of dependencies.)

@brettz9 brettz9 merged commit cc4e1e4 into indexeddbshim:master Feb 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants