Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memoryDatabase config validator #300

Merged
merged 1 commit into from
May 3, 2017

Conversation

lightsofapollo
Copy link
Contributor

Pretty sure this is just a typo now ':memory:' can pass.

(now :memory: can pass)
@lightsofapollo
Copy link
Contributor Author

... The mocha tests actually do use this option so I am not sure how best to add tests for this ?

@lightsofapollo
Copy link
Contributor Author

#301 has more extensive changes but also includes this fix.

@brettz9 brettz9 merged commit d79ba29 into indexeddbshim:master May 3, 2017
@brettz9
Copy link
Collaborator

brettz9 commented May 3, 2017

I don't think the Mocha tests are using the in-memory databases... I don't see the search string "memory" anywhere in the tests-mocha directory. But it is a valid fix which I've merged. Will rebuild dist separately.

@lightsofapollo lightsofapollo deleted the patch-1 branch May 3, 2017 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants