Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove doc html_root_url #292

Merged
merged 1 commit into from
Dec 30, 2023
Merged

Remove doc html_root_url #292

merged 1 commit into from
Dec 30, 2023

Conversation

zachs18
Copy link
Contributor

@zachs18 zachs18 commented Dec 26, 2023

The html_root_url currently links to an old version of the docs, so if you run cargo doc --no-deps on a downstream package that depends on indexmap@2.1.0, intra-doc links to indexmap types will resolve to indexmap@1.9.3 on docs.rs.

@cuviper
Copy link
Member

cuviper commented Dec 29, 2023

Oops! We should just remove this altogether, as it's no longer recommended: rust-lang/api-guidelines#230

@zachs18 zachs18 changed the title Update doc html_root_url Remove doc html_root_url Dec 29, 2023
@zachs18
Copy link
Contributor Author

zachs18 commented Dec 29, 2023

Okay, I've updated the PR to remove the attribute instead of updating it.

@cuviper
Copy link
Member

cuviper commented Dec 30, 2023

Thanks!

@cuviper cuviper merged commit 7e0862c into indexmap-rs:master Dec 30, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants