-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add borsh
serialization support
#313
Conversation
e273293
to
c3909d5
Compare
c3909d5
to
db551fa
Compare
149d560
to
88a5692
Compare
88a5692
to
9a0ca23
Compare
@cuviper the new deserialization code in spite of working correctly, introduced some exploits related with OOM errors. I'm inclined to rollback to |
Please explain this! If there's an "exploit" footgun here, it needs to be commented at the very least. |
@cuviper hm the problem is this deserialization code I wrote is blindly allocating a buffer for incoming items from a stream. the deserialization code in I'll revert the deserialization code to use |
Oh, I see -- I should really add limits to serde |
9a0ca23
to
7add3e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI failed on MSRV --all-features
, since borsh wants 1.66, so I guess we need to reduce that job to the list of features that do work with 1.63. (I don't want to raise MSRV just for an optional feature.)
Your branch is not open to maintainer pushes, so I put suggested changes in my fork: |
@cuviper thanks for the patches! I've included them in this branch |
e4aa6cf
to
b81a4d2
Compare
rebased on 2.2.4 |
This has been published in 2.2.5! |
sweet. thanks! |
Add support to serialize maps and sets with
borsh
.