API integration #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
confxsd
force-pushed
the
api-integration
branch
from
b15a985 to
3008bae
Compare
serefyarar
reviewed
Jan 16, 2024
| }; | ||
|
|
||
| const getAllIndexes = useCallback(async () => { | ||
| if (!viewedProfile || !viewedProfile.id) return; // TODO: handle better maybe? |
There was a problem hiding this comment.
I need to clarify the flow of the 'viewedProfile' variable and the reason it is managed as a session object rather than a route parameter in a seperate session. Due to this approach, it's possible that this variable might not be present. Also, I agree that it could be handled much better.
web-app/src/services/api-service.ts
Outdated
Comment on lines
97
to
98
| private signerPublicKey: string = ''; | ||
| private signerFunction: string = appConfig.defaultCID; |
There was a problem hiding this comment.
Since the API is not all about indexes, these properties ideally should belong to index type, we should talk a little bit about the client structure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uses
dev.index.networkinapiConfig, need to change that in prod