Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial #5

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Initial #5

merged 3 commits into from
Jan 17, 2024

Conversation

serefyarar
Copy link
Contributor

No description provided.

@serefyarar serefyarar requested a review from confxsd January 17, 2024 15:28
confxsd
confxsd previously approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@confxsd confxsd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems nice 🙂👍🏻

maybe constructor params? didn't mark them all but similar cases i guess

@confxsd confxsd dismissed their stale review January 17, 2024 15:41

testing

@serefyarar serefyarar merged commit 3a1998f into dev Jan 17, 2024
@serefyarar
Copy link
Contributor Author

serefyarar commented Jan 17, 2024 •
edited
Loading

I agree with you for constructor params. I will change it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@confxsd confxsd confxsd left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serefyarar @confxsd