-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call Indico API for event creation #243
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adl1995
force-pushed
the
create-event
branch
from
September 18, 2020 15:40
6f24fd1
to
6129458
Compare
adl1995
changed the title
WIP: Call Indico API for event creation
Call Indico API for event creation
Oct 6, 2020
ThiefMaster
reviewed
Oct 6, 2020
@ThiefMaster - I don't think the failing test case is coming from my code. |
ThiefMaster
reviewed
Nov 7, 2020
adl1995
force-pushed
the
create-event
branch
8 times, most recently
from
November 15, 2020 19:57
8a22efa
to
a769b2a
Compare
ThiefMaster
requested changes
Dec 4, 2020
adl1995
force-pushed
the
create-event
branch
2 times, most recently
from
December 9, 2020 06:54
e0bdd19
to
2af0521
Compare
ThiefMaster
force-pushed
the
create-event
branch
from
April 14, 2021 14:50
2af0521
to
45a048b
Compare
ThiefMaster
approved these changes
Apr 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice PR! Works fine :)
ThiefMaster
force-pushed
the
create-event
branch
from
April 14, 2021 15:04
45a048b
to
66008a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #128
Corresponding PR in Indico: indico/indico#4628