Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring & Linting #27

Merged
merged 1 commit into from
Sep 28, 2022
Merged

Refactoring & Linting #27

merged 1 commit into from
Sep 28, 2022

Conversation

indiependente
Copy link
Owner

CHANGES

  • Refactored the prompt to use an Executor
  • Revisited list of enabled linters in golangci-lint, removed deprecated ones and updated code+tests accordingly

VenturaDelMonte
VenturaDelMonte approved these changes Sep 28, 2022
View reviewed changes
Copy link
Collaborator

@VenturaDelMonte VenturaDelMonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only one minor thing to fix.

executor.go
func NewExecutor(srv *server.HTTPServer) func(string) {
return func(s string) {
s = strings.TrimSpace(s)
if s == "bye" || s == "quit" {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty string?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to just do nothing, could be a mistake

@indiependente indiependente self-assigned this Sep 28, 2022
@indiependente indiependente merged commit 2256248 into main Sep 28, 2022
@indiependente indiependente deleted the refactor branch September 28, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VenturaDelMonte VenturaDelMonte VenturaDelMonte approved these changes

Assignees

@indiependente indiependente

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@indiependente @VenturaDelMonte