Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description of client registration variables/properties #122

Merged
merged 7 commits into from
Jul 22, 2024

Conversation

federicaagostini
Copy link
Contributor

@federicaagostini federicaagostini commented Jun 28, 2024

In particular:

  • IAM_CLIENT_REGISTRATION_ALLOW_FOR
  • IAM_CLIENT_REGISTRATION_ENABLE
  • IAM_DEFAULT_ACCESS_TOKEN_VALIDITY_SECONDS
  • IAM_DEFAULT_DEVICE_CODE_VALIDITY_SECONDS
  • IAM_DEFAULT_ID_TOKEN_VALIDITY_SECONDS
  • IAM_DEFAULT_REFRESH_TOKEN_VALIDITY_SECONDS

@federicaagostini federicaagostini marked this pull request as draft June 28, 2024 15:23
@federicaagostini
Copy link
Contributor Author

I've set this PR as draft since I don't know if we want to fix the already released but not advertized environment variables for AT, RT, ID token and device code lifetimes. In particular, @giacomini suggested to prefix all of them with IAM_, as all of the other iam: properties.

Also, let me know if we also want to create another page to show how to configure the client-registration with an application.yml file (e.g. copy-and-paste plus explain those properties).

@rmiccoli
Copy link
Contributor

rmiccoli commented Jul 2, 2024

I've set this PR as draft since I don't know if we want to fix the already released but not advertized environment variables for AT, RT, ID token and device code lifetimes. In particular, @giacomini suggested to prefix all of them with IAM_, as all of the other iam: properties.

Also, let me know if we also want to create another page to show how to configure the client-registration with an application.yml file (e.g. copy-and-paste plus explain those properties).

I agree to rename those variables by adding the IAM prefix.
Then, I think it is ok to explain the variables there as all other configurations are also listed.

@federicaagostini
Copy link
Contributor Author

I've set this PR as draft since I don't know if we want to fix the already released but not advertized environment variables for AT, RT, ID token and device code lifetimes. In particular, @giacomini suggested to prefix all of them with IAM_, as all of the other iam: properties.
Also, let me know if we also want to create another page to show how to configure the client-registration with an application.yml file (e.g. copy-and-paste plus explain those properties).

I agree to rename those variables by adding the IAM prefix.

This should be solved with indigo-iam/iam#807

Then, I think it is ok to explain the variables there as all other configurations are also listed.

@federicaagostini
Copy link
Contributor Author

federicaagostini commented Jul 16, 2024

Then, I think it is ok to explain the variables there as all other configurations are also listed.

Done

@federicaagostini federicaagostini changed the title Add description of client registration-related env variables Add description of client registration variables/properties Jul 16, 2024
@federicaagostini federicaagostini changed the base branch from v1.9.0 to v1.10.0 July 22, 2024 14:44
@federicaagostini federicaagostini removed the request for review from giacomini July 22, 2024 14:44
@enricovianello enricovianello marked this pull request as ready for review July 22, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants