Do not provide message on external authn error

indigo-iam · Jul 4, 2023 · 2655b49 · 2655b49
1 parent e5cbf34
commit 2655b49
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/...ogin-service/src/main/java/it/infn/mw/iam/authn/ExternalAuthenticationFailureHandler.java b/...ogin-service/src/main/java/it/infn/mw/iam/authn/ExternalAuthenticationFailureHandler.java
@@ -48,7 +48,6 @@ private String buildRedirectURL(AuthenticationException exception) {
 
     return UriComponentsBuilder.fromPath("/login")
       .queryParam("error", "true")
-      .queryParam("externalAuthenticationError", errorMessage)
       .build(true)
       .toString();
   }

diff --git a/iam-login-service/src/main/webapp/WEB-INF/views/iam/login.jsp b/iam-login-service/src/main/webapp/WEB-INF/views/iam/login.jsp
@@ -48,7 +48,6 @@
             <c:if test="${ param.externalAuthenticationError != null }">
                 <div class="alert alert-danger">
                     <strong>External authentication error</strong>
-                    <div>${param.externalAuthenticationError}</div>
                 </div>
             </c:if>
 

diff --git a/...test/java/it/infn/mw/iam/test/ext_authn/oidc/validator/OidcValidatorIntegrationTests.java b/...test/java/it/infn/mw/iam/test/ext_authn/oidc/validator/OidcValidatorIntegrationTests.java
@@ -105,8 +105,8 @@ public void testValidatorError() throws JOSEException,
         UriComponentsBuilder.fromUri(response.getHeaders().getLocation()).build();
 
     assertThat(locationUri.getPath(), equalTo("/login"));
-    assertThat(locationUri.getQueryParams().keySet(), hasItem("externalAuthenticationError"));
-    assertThat(locationUri.getQueryParams().getFirst("externalAuthenticationError"), is("always%20fails"));
+    assertThat(locationUri.getQueryParams().keySet(), hasItem("error"));
+    assertThat(locationUri.getQueryParams().getFirst("error"), is("true"));
   }