Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix refresh token lifetime value in case of client credentials or implicit grant types #582

Merged
merged 2 commits into from
Apr 13, 2023

Conversation

rmiccoli
Copy link
Contributor

@rmiccoli rmiccoli commented Mar 2, 2023

When a client is dynamically registered and contains client credentials or implicit as grant types, the refresh token lifetime is unnecessarily set to zero.

when a client is dynamically registered and contains client credentials or
implicit as grant types. In those cases, the refresh token lifetime is set
to zero unnecessarily, since no refresh token is issued during the client
credentials/implicit flow.
@sonarcloud
Copy link

sonarcloud bot commented Mar 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@enricovianello enricovianello changed the title Fix refresh token setting generated by a dynamically registered client Fix refresh token lifetime value in case of client credentials or implicit grant types Apr 13, 2023
@enricovianello enricovianello merged commit 7247699 into develop Apr 13, 2023
@enricovianello enricovianello deleted the issue-575 branch April 13, 2023 09:30
@sonarcloud
Copy link

sonarcloud bot commented Apr 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

federicaagostini added a commit that referenced this pull request Jun 20, 2023
federicaagostini added a commit that referenced this pull request Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants