Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new JWT profile that rename 'groups' claim with 'roles' #637

Merged
merged 17 commits into from
Sep 14, 2023

Conversation

enricovianello
Copy link
Member

@enricovianello enricovianello commented Jul 27, 2023

The 'kc' profile wants to allow the integration with a Keycloak environment. Having "roles" claim instead of "groups" allows integration with the OIDC client - a conteinerised MISP deployment - which requires them to map IAM users.

This PR add this "kc" profile and:

  • add access-token builder tests
  • add scope-profile resolver tests

enricovianello and others added 3 commits July 27, 2023 10:03
- Add access-token builder tests
- Add scope-profile resolver tests
- TO-DO: test userinfo/id-token/introspection responses
@enricovianello
Copy link
Member Author

@jamesacris we opened this new PR and decided to rename profile from "keycloak" to "kc" because we want to avoid "copyright" problems :) You can checkout the new branch "issue-556-reloaded" if you want to contribute but the idea is that by the end of this morning we finalise tests and create a IAM docker image with these changes that can be tested. This docker image won't contain all the other stuff related to IAM v1.8.3 because it will be easier for you to upgrade your deployment with the official v1.8.3 when it will be released.

@enricovianello enricovianello marked this pull request as ready for review September 6, 2023 12:41
@enricovianello enricovianello changed the title Add 'kc' JWT profile Add new JWT profile that rename 'groups' claim with 'roles' Sep 14, 2023
@enricovianello enricovianello merged commit 283d791 into develop Sep 14, 2023
7 checks passed
@enricovianello enricovianello deleted the issue-556-reloaded branch September 14, 2023 13:41
@sonarcloud
Copy link

sonarcloud bot commented Sep 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

97.1% 97.1% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants