Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for an optional "Apply for an account with eduGAIN" button #665

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

Sae126V
Copy link
Contributor

@Sae126V Sae126V commented Oct 30, 2023

Resolves #522

Added an anchor tag with the content saying "Apply for an account with eduGAIN".

@Sae126V Sae126V changed the title Issue 522 Request for an optional "Apply for an account with eduGAIN" button Oct 30, 2023
@Sae126V Sae126V changed the base branch from master to develop October 30, 2023 16:32
@Sae126V
Copy link
Contributor Author

Sae126V commented Oct 30, 2023

eduGAIN_Btn

[Sample on how it looks like]

@Sae126V Sae126V marked this pull request as ready for review November 3, 2023 14:59
Copy link
Contributor

@rmiccoli rmiccoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@giacomini
Copy link
Contributor

Not necessarily with this PR, but we should probably use the same terminology commonly found on web services: "sign up" or "register".

Copy link
Contributor

@rmiccoli rmiccoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enable the "Apply for an account with EduGAIN" button only if SAML is enabled.
e.g. <c:if test="${loginPageConfiguration.samlEnabled}">

@Sae126V
Copy link
Contributor Author

Sae126V commented Nov 17, 2023

Enable the "Apply for an account with EduGAIN" button only if SAML is enabled. e.g. <c:if test="${loginPageConfiguration.samlEnabled}">

Make sense. This will be visible only if SAML is enabled now.

@enricovianello
Copy link
Member

I think there's not only EduGAIN as a SAML provider. If you configured another SAML remote provider you'll see a non sense button with the label "Apply for an account with EduGAIN" or am I wrong? And if we add this button for each OIDC/SAML provider configured the login page could contain lots of buttons. Probably we need to add a configuration parameter for each SAML endpoint configured that enables or not its own, specific "Apply for an account with ..." button.

Copy link

sonarcloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@rmiccoli rmiccoli merged commit 9407a9d into develop Feb 8, 2024
5 checks passed
@rmiccoli rmiccoli deleted the issue-522 branch February 8, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request for an optional "Apply for an account with eduGAIN" button
4 participants