-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VO members can re-sign the AUP at any time #757
Conversation
* Add API and service methods to change client status * Add new columns for client status * Set status as active for new client * Add suspended label next to client name * Add column status_changed_by to client_details * Make client suspension details available to client owner
Two points to be considered
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found that the PATCH endpoint you added already exists through another API (it needs a little fix). Probably with less changes it works too!
iam-login-service/src/main/java/it/infn/mw/iam/api/aup/AupSignaturePageController.java
Outdated
Show resolved
Hide resolved
iam-login-service/src/main/java/it/infn/mw/iam/api/aup/AupSignaturePageController.java
Outdated
Show resolved
Hide resolved
iam-login-service/src/main/webapp/resources/iam/apps/dashboard-app/services/aup.service.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main comments are: there's no really a need to add an AupResignedEvent (the AupSignedEvent can be used) and probably there's also no need to add endpoint and users can sign again by using a POST on '/iam/aup/signature'
iam-login-service/src/main/java/it/infn/mw/iam/audit/events/aup/AupResignedEvent.java
Outdated
Show resolved
Hide resolved
...service/src/main/webapp/resources/iam/apps/dashboard-app/components/user/user.component.html
Outdated
Show resolved
Hide resolved
...n-service/src/main/webapp/resources/iam/apps/dashboard-app/components/user/user.component.js
Outdated
Show resolved
Hide resolved
iam-login-service/src/main/webapp/resources/iam/apps/dashboard-app/services/aup.service.js
Outdated
Show resolved
Hide resolved
iam-login-service/src/main/java/it/infn/mw/iam/api/aup/AupSignaturePageController.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably we need to hide the button in case of admin is viewing a user page
@@ -66,7 +66,7 @@ <h1> | |||
|
|||
<!-- Send reset password email or change password--> | |||
<user-password user="$ctrl.user"></user-password> | |||
|
|||
<aup-resign user="$ctrl.user"></aup-resign> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This object is visible to both admins and users but admins can enter user's page and will find this button that acts for theirselves and not for the user. This object should probably be hidden in case of !$ctrl.isMe() && $ctrl.isVoAdmin()
. Could you check this behavior and confirm this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I have checked if admin enter user's page admin can see the button.
If I add ng-if="$ctrl.isMe()"
in aup-resign
tag then it is working as expected.
I changed base branch to develop, having merged #705 into develop branch |
Quality Gate passedIssues Measures |
Fixes #736