Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to notes being customised #782

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

Add support to notes being customised #782

wants to merge 9 commits into from

Conversation

Sae126V
Copy link
Contributor

@Sae126V Sae126V commented Jun 6, 2024

No description provided.

@Sae126V Sae126V marked this pull request as ready for review June 6, 2024 07:29
@Sae126V Sae126V modified the milestone: v1.8.3 Jun 6, 2024
@Sae126V Sae126V force-pushed the issue-759-registration-ui branch from 185b3d4 to e8a18f5 Compare June 7, 2024 06:47
@Sae126V Sae126V self-assigned this Jun 7, 2024
@enricovianello enricovianello linked an issue Jun 14, 2024 that may be closed by this pull request
User registration form "Notes" field usability issue #759
Open
@rmiccoli
Copy link
Contributor

Perhaps we can put an if statement in the email template (adminHandleRequest.ftl) so that notes are only shown if the content is not empty.
e.g.

<#if notes?has_content>
Notes:
${notes}
</#if>

@Sae126V
Copy link
Contributor Author

Sae126V commented Jul 4, 2024

Perhaps we can put an if statement in the email template (adminHandleRequest.ftl) so that notes are only shown if the content is not empty. e.g.

<#if notes?has_content>
Notes:
${notes}
</#if>

Ahh! You are right @rmiccoli 👍 . Added in 14800ca

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

enricovianello
enricovianello requested changes Jul 11, 2024
View reviewed changes
Copy link
Member

@enricovianello enricovianello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started the review and mainly the big change suggested is to use an implementation of the RequestValidatorService instead of adding the validation logic into the DefaultRegistrationRequestService. I know I'm a bit annoying but I'd prefer to keep things separated, having something similar already done for CERN purposes.

...gin-service/src/main/java/it/infn/mw/iam/registration/DefaultRegistrationRequestService.java Show resolved Hide resolved
iam-login-service/src/main/java/it/infn/mw/iam/registration/RegistrationRequestService.java Outdated Show resolved Hide resolved
...gin-service/src/main/java/it/infn/mw/iam/registration/DefaultRegistrationRequestService.java Outdated Show resolved Hide resolved
iam-login-service/src/main/resources/application.yml
@@ -154,6 +154,9 @@ iam:
oidc-issuer: ${IAM_REGISTRATION_OIDC_ISSUER:https://example.org}
saml-entity-id: ${IAM_REGISTRATION_SAML_ENTITY_ID:urn:example}
add-nickname-as-attribute: ${IAM_ADD_NICKNAME_AS_ATTRIBUTE:false}
fields:
notes:
field-behaviour: ${IAM_REGISTRATION_NOTES_FIELD_BEHAVIOUR:mandatory}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we add this env variable we should add also the others: IAM_REGISTRATION_GIVEN_NAME_BEHAVIOUR, etc. I think we can avoid adding these lines and keep the default value as MANDATORY on this line https://github.com/indigo-iam/iam/pull/782/files#diff-eb3a40a655172a85a4ebaccf2dba240d9b4f294761e61a5631af9892aa95a49fR206

...in-service/src/test/java/it/infn/mw/iam/test/registration/RegistrationUnprivilegedTests.java Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
96.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@rmiccoli
Copy link
Contributor

Note that recently this check https://github.com/Sae126V/iam/blob/issue-759-registration-ui/iam-login-service/src/main/java/it/infn/mw/iam/registration/RegistrationRequestDto.java#L97 has been added for the Notes field and I saw it is already merged in this PR. I think this check should be removed otherwise the behavior of the optional or hidden Notes field does not work as it should.

@Sae126V
Update code to apply custom directive directly to an element
57b878d 
- Fix an issue with cern profile doing notes sanity check
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmiccoli rmiccoli rmiccoli left review comments

@enricovianello enricovianello enricovianello requested changes

@federicaagostini federicaagostini Awaiting requested review from federicaagostini

@garaimanoj garaimanoj Awaiting requested review from garaimanoj

Requested changes must be addressed to merge this pull request.

Assignees

@Sae126V Sae126V

Labels
priority/high status/changes-requested status/in-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User registration form "Notes" field usability issue
3 participants
@Sae126V @rmiccoli @enricovianello