Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AUP exemption #811

Open
wants to merge 36 commits into
base: develop
Choose a base branch
from
Open

AUP exemption #811

wants to merge 36 commits into from

Conversation

garaimanoj
Copy link
Contributor

No description provided.

@garaimanoj garaimanoj changed the base branch from master to develop July 22, 2024 14:50
@garaimanoj garaimanoj self-assigned this Jul 22, 2024
@garaimanoj garaimanoj linked an issue Jul 22, 2024 that may be closed by this pull request
The AUP requirement should be configurable per account #737
Open
@enricovianello enricovianello added status/in-progress component/db Issue that includes one or more db migrations labels Aug 7, 2024
@garaimanoj garaimanoj marked this pull request as ready for review August 16, 2024 12:57
@rmiccoli
Copy link
Contributor

rmiccoli commented Aug 20, 2024 •
edited
Loading

When the account is set up as a service account, the signature of the aup is skipped (if it is defined), but what if it accidentally goes to the /iam/aup/sign endpoint and accepts the aup? the exception is thrown at this time, I don't know if the ExceptionHandler should be added here as well

iam/iam-login-service/src/main/java/it/infn/mw/iam/api/aup/AupSignaturePageController.java

Line 99 in bddf581

public ModelAndView signAup(HttpServletRequest request, HttpServletResponse response,

@garaimanoj
Copy link
Contributor Author

When the account is set up as a service account, the signature of the aup is skipped (if it is defined), but what if it accidentally goes to the /iam/aup/sign endpoint and accepts the aup? the exception is thrown at this time, I don't know if the ExceptionHandler should be added here as well

iam/iam-login-service/src/main/java/it/infn/mw/iam/api/aup/AupSignaturePageController.java

Line 99 in bddf581

public ModelAndView signAup(HttpServletRequest request, HttpServletResponse response,

I am going to add the exception handler and a test.

@rmiccoli rmiccoli changed the title Issue 737 aup exemption AUP exemption Sep 3, 2024
enricovianello
enricovianello requested changes Sep 13, 2024
View reviewed changes
Copy link
Member

@enricovianello enricovianello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we add things to SCIM user that are not in the SCIM protocol we need to add them inside ScimIndigoUser extension object

iam-login-service/src/main/java/it/infn/mw/iam/api/scim/model/ScimUser.java Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmiccoli rmiccoli rmiccoli approved these changes

@enricovianello enricovianello Awaiting requested review from enricovianello

Requested changes must be addressed to merge this pull request.

Assignees

@garaimanoj garaimanoj

Labels
component/db Issue that includes one or more db migrations kind/feature status/in-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The AUP requirement should be configurable per account
3 participants
@garaimanoj @enricovianello @rmiccoli