Fix AUP signature validity #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- when signatureValidityInDays is 0, hide the aup reminders from the interface - when signatureValidityInDays is 0, ignore the reminders validation (put the default value)
enricovianello
approved these changes
Aug 27, 2024
enricovianello
requested changes
Aug 27, 2024
...in-service/src/main/java/it/infn/mw/iam/api/aup/model/AupRemindersAndSignatureValidator.java
Outdated
Show resolved
Hide resolved
...in-service/src/main/java/it/infn/mw/iam/api/aup/model/AupRemindersAndSignatureValidator.java
Outdated
Show resolved
Hide resolved
and put the aup reminders as empty string if signature validity is 0
...in-service/src/main/java/it/infn/mw/iam/api/aup/model/AupRemindersAndSignatureValidator.java
Outdated
Show resolved
Hide resolved
...rvice/src/main/webapp/resources/iam/apps/dashboard-app/components/aup/aup.create.dialog.html
Show resolved
Hide resolved
...service/src/main/webapp/resources/iam/apps/dashboard-app/components/aup/aup.edit.dialog.html
Show resolved
Hide resolved
|
enricovianello
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The custom validator for AUP signature validity and AUP reminders, introduced within IAM v1.10.0, checks that the value of the AUP reminders is less than the AUP signature validity. This PR fixes the case AUP signature validity is equal to 0. In particular: