Fix bug in relative positioning of Lacerta MFOC #1924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid problematic signed to unsigned conversion of -1 when computing the new absolute focus position.
|
May also fix #1834 |
|
@singraber good point - thx for the fix |
knro
pushed a commit
to knro/indi
that referenced
this pull request
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #1842. Lacerta MFOC with newer firmware (tested with version 3.1.01, driver
indi_lacerta_mfoc_fmc_focus) fails to correctly change position when a relative change in theFocus Indirection is selected.The problematic code is
(ticks * (dir == FOCUS_INWARD ? -1 : 1)), whereticksis an unsigned and-1a signed integer.-1gets converted into a huge unsigned value before the multiplication is carried out. Hence, the new desiredtargetTicksvalue is huge instead of decreased by the desired amount.The same code can be found in the "old" driver
lacerta_mfoc.cpp, the patch is applied there as well (untested).