Flip-flat: Allow handshake without ioctl on virtual serial connection #1987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (revised) If initial IOCTL call fails, try premptively pinging the flip-flat anyway, so that the handshake can succeed in the case of a virtual serial port (e.g. a pty with no IOCTL).
|
Test and works fine on FlipFlat |
|
thank you for testing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… (revised)
If initial IOCTL call fails, try premptively pinging the flip-flat anyway, so that the handshake can succeed in the case of a virtual serial port (e.g. a pty with no IOCTL).
This shouldn't impact flip-flat driver users with 'real' or clone hardware, but will allow hardware implementations that use a virtual serial port (e.g. in my case, using stepper/relay hats via gpio on a rpi with a small python daemon)