Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: update focuser temperature in alluna tcs2 driver #2055

Merged
merged 5 commits into from
May 5, 2024
Merged

Bugfix: update focuser temperature in alluna tcs2 driver #2055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1a3b90a
Inform clients when temperature changes
peter-englmaier Apr 27, 2024
e828d3f
Optimize update interval for temperature and fan speed
peter-englmaier Apr 27, 2024
467586c
Update log message
peter-englmaier Apr 27, 2024
91f873c
Fix copyright message to reflect actual authorship
peter-englmaier Apr 27, 2024
d6ae851
Merge branch 'indilib:master' into rebased
peter-englmaier May 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions drivers/focuser/alluna_tcs2.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,7 +594,7 @@ bool AllunaTCS2::AbortFocuser()

void AllunaTCS2::TimerHit()
{
//LOG_INFO("TimerHit");
LOG_INFO("TimerHit");
if (!isConnected())
return; // No need to reset timer if we are not connected anymore

Expand Down Expand Up @@ -739,7 +739,7 @@ bool AllunaTCS2::getTemperature()
// d#{ambient-humidity}<CR><LF>

std::chrono::duration<double> seconds = std::chrono::system_clock::now() - last_temp_update;
if ( !first_run && seconds.count() < 300 ) // update every 300 seconds
if ( !first_run && seconds.count() < 10 ) // update every 10 seconds
{
if (tcs.try_lock()) {
tcs.unlock(); // we need to get lock, to make TimerHit behave the same when we block reading temperature
Expand Down Expand Up @@ -780,6 +780,7 @@ bool AllunaTCS2::getTemperature()
receiveDone();
isGetTemperature=false;
TemperatureNP.setState(IPS_OK);
TemperatureNP.apply(); // update clients
break;
default: // unexpected output
LOGF_ERROR("GetTemperatures: unexpected response (%s)", res);
Expand Down Expand Up @@ -865,7 +866,7 @@ bool AllunaTCS2::setStepping(SteppingMode mode)
char cmd[DRIVER_LEN] = {0};
steppingMode=mode;
value = (mode == SPEED) ? 0 : 1;
LOGF_INFO("Setting stepping mde to: %s", (mode==SPEED)?"SPEED":"micro");
LOGF_INFO("Setting stepping mode to: %s", (mode==SPEED)?"SPEED":"micro");
LOGF_INFO("Setting stepping mode to: %d", value);
snprintf(cmd, DRIVER_LEN, "SetFocuserMode %d\n", value);
return sendCommand(cmd);
Expand Down Expand Up @@ -977,7 +978,7 @@ bool AllunaTCS2::getFanPower()
char res[DRIVER_LEN] = {0};

std::chrono::duration<double> seconds = std::chrono::system_clock::now() - last_temp_update;
if ( !first_run && seconds.count() < 3 ) // update every 3 seconds
if ( !first_run && seconds.count() < 30 ) // update every 30 seconds
{
if (tcs.try_lock()) {
tcs.unlock(); // we need to get lock, to make TimerHit behave the same when we block reading temperature
Expand Down
12 changes: 3 additions & 9 deletions drivers/focuser/alluna_tcs2.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,8 @@
/*
Skeleton Focuser Driver
Alluna TCS2 Focus, Dust Cover, Climate, Rotator, and Settings
(Dust Cover and Rotator are not implemented)

Modify this driver when developing new absolute position
based focusers. This driver uses serial communication by default
but it can be changed to use networked TCP/UDP connection as well.

Copyright(c) 2019 Jasem Mutlaq. All rights reserved.

Thanks to Rigel Systems, especially Gene Nolan and Leon Palmer,
for their support in writing this driver.
Copyright(c) 2022 Peter Englmaier. All rights reserved.

This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Lesser General Public
Expand Down
Loading