Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tracking code #2105

Merged
merged 9 commits into from
Aug 27, 2024
Merged

Update Tracking code #2105

merged 9 commits into from
Aug 27, 2024

Conversation

knro
Copy link
Contributor

@knro knro commented Aug 27, 2024

Update skywatcher tracking code to use @jochym updated tracking code from Celestron Auxiliary driver. Not properly tested yet.

@knro knro merged commit 6311d15 into indilib:master Aug 27, 2024
11 checks passed
@knro knro deleted the skywatcher_tracking branch August 27, 2024 19:15
@jochym
Copy link
Contributor

jochym commented Aug 28, 2024

That was a lot of changes. Was this all required to implement the predictive tracking, or you just took the opportunity to clean things up?
I am asking because I am planning a second attempt at making it work well and fully controlled, and I would like to understand your port, just to make it easier for eventual factoring (which we should do in the future).
Please, if you have any test results, write to me. It is quite valuable for thinking about how to improve it.

BTW: I have noticed that you have - in your changes - the call to functions updating position of the target if it moves on the sky. CAUX does not have that - and it would make tracking of comets or even satellites possible. How is it working and what is the source of new positions (kstars, other). Maybe we can implement some interface for this type of tracking. In principle, it should be possible - there is no difference between sky tracking and sky+movement for the AltAz mount.

@knro
Copy link
Contributor Author

knro commented Aug 28, 2024

Mostly clean up. Also, I guess universal ROR changes were also in there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants