-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc changes cherrypicked from actx branch #71
Conversation
The Gitlab CI is running at |
921583b
to
b66ac09
Compare
Thanks! This looks good to me outside of the two things we're discussing above. |
cc @xywei |
f81097d
to
1762a5d
Compare
Thanks for working on this. There are still many warts here, but this is at least a step in the right direction. |
Pushed some changes, LGTM if it passes (I'll work on it if it doesn't). |
@inducer Did you take a look if the |
It seems that |
Just from a quick skim in
and I assume that The functions in there do a |
I think it'd be even safer to just create a new |
Mostly stuff from #56 in an attempt to make that diff smaller!
TODO:
TreeOfBoxes
TreeOfBoxes