Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix startup when no write permissions #659

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Conversation

fffergal
Copy link
Contributor

Making the parent directories of the config file could cause an exception if the process doesn't have write permissions. This is common with remote debugging in containers. Catch exceptions, log, and continue, same as other parts of the settings that cannot raise exceptions. The next stage of saving the config file will also fail, but this is already caught.

Making the parent directories of the config file could cause an exception if the process doesn't have write permissions. This is common with remote debugging in containers. Catch exceptions, log, and continue, same as other parts of the settings that cannot raise exceptions. The next stage of saving the config file will also fail, but this is already caught.
@fffergal
Copy link
Contributor Author

Was waiting for checks to run before making ready, but I don't think they are going to run without intervention so making ready now. Anything I can do to make this easier to merge and release, just let me know! Thank you.

@fffergal fffergal marked this pull request as ready for review August 29, 2024 11:09
@inducer inducer merged commit e67fe51 into inducer:main Aug 29, 2024
9 checks passed
@inducer
Copy link
Owner

inducer commented Aug 29, 2024

Thanks!

@fffergal
Copy link
Contributor Author

Thanks for accepting! I've played around with it a bit like this. I can get into debugging now, but there are errors that appear in the console fairly often, and a pop up when you try to quit. Ctrl-c still works. So I may add some other fix ups later.

@inducer
Copy link
Owner

inducer commented Aug 29, 2024

Sounds good. Happy to consider further PRs. And thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants